Formatted #12
Open
Formatted #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfiguiere
reviewed
Dec 11, 2017
gphotofs.c
Outdated
| if (ret > 1) { | ||
|
|
||
| g_fprintf(stderr, "Multiple cameras detected on specified port. Model is required.\n"); | ||
| return GP_ERROR; |
There was a problem hiding this comment.
the list is never freed. Here or below.
There was a problem hiding this comment.
Is it necessary? I'm considering this to be the same case as ret != 0, where the whole program exits immediately without proceeding to the actual mount.
hfiguiere
reviewed
Dec 11, 2017
gphotofs.c
Outdated
| return GP_ERROR; | ||
| } else if (ret < 1) { | ||
| g_fprintf(stderr, "No cameras detected on specified port.\n"); | ||
| return ret; |
There was a problem hiding this comment.
as above. cameraList is not freed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make --port work right as per #11