new camera_keep_device_on() function (less noise in debug log) #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of calling ptp_canon_eos_keepdeviceon() in e.g. camera_wait_for_event() directly for every invocation (often twice), which can lead to dozens of those calls per second, this patch limits the number to 1 every 10 seconds. The camera_prepare_capture + ptp_check_eos_events + keepdeviceon block in camera_lookup_by_property has been removed completely as this function is only called from within camera_wait_for_event() where those checks have been made just prior to the call to camera_lookup_by_property. Furthermore: ptp_check_eos_events() will now only be called inside camera_wait_for_event if the queue of already transmitted events is drained first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling ptp_canon_eos_keepdeviceon() in e.g. camera_wait_for_event() directly for every invocation (often twice), which can lead to dozens of those calls per second, this patch limits the number to 1 every 10 seconds.
The camera_prepare_capture + ptp_check_eos_events + keepdeviceon block in camera_lookup_by_property has been removed completely as this function is only called from within camera_wait_for_event() where those checks have been made just prior to the call to camera_lookup_by_property.
Furthermore: ptp_check_eos_events() will now only be called inside camera_wait_for_event if the queue of already transmitted events is drained first.