Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly cosmetic #1026

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Mostly cosmetic #1026

merged 3 commits into from
Sep 23, 2024

Conversation

axxel
Copy link
Contributor

@axxel axxel commented Sep 23, 2024

3 random commits, pushing it now because of the first one (fix for a minor display bug I introduced in the last PR).

@msmeissn msmeissn merged commit db4320a into gphoto:master Sep 23, 2024
3 of 4 checks passed
@@ -4628,27 +4628,15 @@ _ptp_sony_getalldevicepropdesc (PTPParams* params, uint16_t opcode)
/* debug output to see what changes */
if (i != params->nrofdeviceproperties) {
switch (dpd.DataType) {
case PTP_DTC_INT8:
#define CHECK_CHANGED(type) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this macro definition be moved outside of the scope?

@axxel axxel deleted the mostly-cosmetic branch September 24, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants