V5.3.3 #366
Merged
V5.3.3 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the erratic behavior from the outer cyclotron when overheating in 84/89 mode by asserting a red colour scheme if we are in one of the two colour-shift firing modes, and then only using the special fade code if we are not overheating.
Fixes issues where if pack overheating is triggered by the wireless module, it will fail if either the wand is turned off or no wand is connected.
Updates several issues with the DIY guide that incorrectly referred to the old Arduino Nano pins when referencing the new Mega2560 Pro Mini board. The new board uses the exact same pinout as the GPStar Wand PCB and should be treated accordingly.
Thanks to Graham Starke from the HasLab Ghostbusters Modders group we now have a clean recording of the GB1 rooftop barrel pop sound.
For people who built their pack kits according to the original installation instructions (the majority of users), it was specified that the right channel should be the "main" speaker while the left channel should be the "sub" speaker. In this configuration, the main sound should be in the right channel, not the left. The original file is now 'alt'.
This change implements the ability to switch the wand to standalone mode dynamically rather than needing to flash a unique binary. To enable standalone mode, bridge the TX and RX pins on the Neutrona Wand board while powering up.
Fixes missing definition for the GBFE pack freeze sound, fixes position of volume reset when switching to standalone mode on the wand, minor typo fix
This removes b_sync_light as it was an unnecessary variable, and prevents the top LED from getting stuck in the on state when transitioning to standalone mode.
This changes the constant variables with lowercase names into preprocessor defines with uppercase names. It also clarifies what a few of the previously ambiguous pins actually do.
This removes unnecessary includes, does proper integer conversion from booleans in Serial.h, and corrects the colors for the year mode selection switch inner cyclotron switch panel.
Fixes Frutto LED panel not remaining off while ramping down which resolves #361 and adds a new brass pack shutdown sound from Aces6469
Updates the brass pack switch panel shutoff functionality to also occur when ribbon cable alarm is active, when overheat is active, and when the button mash freeze lockout is active.
There were a lot of unnecessary calls to the full bargraph reset function and lots of unnecessary explicit multiplier assignments which are better suited to a function dedicated to setting the multiplier.
Fixes wand idle hum overlap when recovering from overheat, fixes overlapping pack startup sounds when recovering from overheat, makes it so wand bootup sounds will only be sent if the pack is not already playing its own bootup sound, fixes wand function names to more accurately describe what they do, cleaned up code relating to overheat an AL/FE startup ramps, removed legacy wand variables from single shot blaster.
This moves the overheating initiator on the pack into a dedicated function rather than having the functionality duplicated across three separate call locations. Likewise it creates a dedicated function for the quick vent start for future extensibility.
This fixes the pack on/off buttons inadvertently ignoring pack state, and fixes the manual vent button not working unless a wand is connected (which is no longer necessary).
Extends the fade effect for the 84/89 cyclotron to fade out after one additional movement, which both makes the effect look less jerky and more closely represents how the animation looked in the video game.
This resolves #354 by fixing the out-of-sequence cyclotron LEDs when overheat is in progress in 84/89 year mode.
|
PR created, started working on the bugfix list but could use some help there @nomakewan |
This fixes the seizure-inducing outer cyclotron LEDs in Holiday and Spectral firing modes for good. While there is room for improvement that can come with v6 when the LED code gets overhauled.
|
Just tossed in one last fix since it was easy to do. I'm going to write up a text-based changelog on my end and then adapt it to the PR format per your request. Stand by! |
This fixes the Afterlife/Frozen Empire powercell SFX still playing during button mash lockout.
Additional conditional checks added to Afterlife/Frozen Empire powercell sound.
Makes sure that if we start a button mash sequence on the pack and the pack thinks the wand is firing, we make sure that we reset all the firing-related flags and sounds.
Prevents noisy overlaps of wand restart sounds in 84/89, makes certain that the button mash restart will always occur even when extra wand sounds are disabled, and cleans up some powercell and button mash checks on the pack.
Fixes missing whitespace before braces
nomakewan
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
Changes all look great on my end. My pack demo seems to be working well and the web functions all work as expected even without a wand connected.
I'm going to run a few final quick tests on my bench wand just to be sure but I'm slapping my seal of approval on this PR.
EDIT: Did my test. Did notice something but it's not a bug and it only affects standalone mode so I'll hold off until 5.3.4. Everything else worked brilliantly. Click it and ship it! (Assuming you guys likewise have successful tests of course)
|
I ran out of time for testing this morning, I need to go make sure some theater students don't cut their fingers off in the woodshop, so I will try to get to testing on my stuff later today. |
gpstar81
approved these changes
Aug 24, 2024
|
Since everyone added their review and approval, I've just loaded up the latest and tested without any obvious issues. Calling this one done and ready for announcement when the support page can be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved Issues:
#354
#358
#359
#360
#361
Ghosts Busted:
New Features:
This release requires updating of all 3 devices (pack, wand, wireless/attenuator) and updating of sound effects for your SD cards.