Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: don't allow tools to be removed from the catalog modal #285

Merged
merged 1 commit into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions components/chat/chatBar/commands.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -204,22 +204,6 @@ export default function Commands({
]);
setToolCatalogOpen(false);
}}
removeTool={(tool) => {
socket?.emit('removeTool', tool);
setMessages((prev) => [
...prev,
{
type: MessageType.Alert,
icon: <GoTools className="mt-1" />,
name: prev ? prev[prev.length - 1].name : undefined,
message: `Removed ${tool
.split('/')
.pop()
?.replace(/-/g, ' ')
.replace(/\b\w/g, (c) => c.toUpperCase())}`,
},
]);
}}
isOpen={toolCatalogOpen}
setIsOpen={setToolCatalogOpen}
/>
Expand Down
8 changes: 1 addition & 7 deletions components/chat/chatBar/toolCatalog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,13 @@ interface ToolCatalogModalProps {
isOpen: boolean;
setIsOpen: (open: boolean) => void;
addTool: (tool: string) => void;
removeTool: (tool: string) => void;
}

const ToolCatalogModal: React.FC<ToolCatalogModalProps> = ({
tools,
isOpen,
setIsOpen,
addTool,
removeTool,
}) => {
return (
<Modal
Expand All @@ -31,11 +29,7 @@ const ToolCatalogModal: React.FC<ToolCatalogModalProps> = ({
>
<ModalContent>
<ModalBody>
<ToolCatalog
tools={tools}
addTool={addTool}
removeTool={removeTool}
/>
<ToolCatalog tools={tools} addTool={addTool} />
</ModalBody>
</ModalContent>
</Modal>
Expand Down
7 changes: 0 additions & 7 deletions components/edit/configure/imports.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -173,13 +173,6 @@ const Imports: React.FC<ImportsProps> = ({
addTool={(tool) => {
setTools([...(tools || []), tool]);
}}
removeTool={(tool) => {
if (isRemote(tool)) {
deleteRemoteTool(tool);
} else {
setTools(tools?.filter((t) => t !== tool) || []);
}
}}
/>
{enableLocal && (
<Button
Expand Down
18 changes: 5 additions & 13 deletions components/edit/configure/imports/toolCatalog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -374,18 +374,13 @@ const featuredTools: FeaturedTools = {
interface ToolCatalogProps {
tools: string[] | undefined;
addTool: (tool: string) => void;
removeTool: (tool: string) => void;
}

interface ToolsSiteResponse {
tools: Record<string, Tool[]>;
}

const ToolCatalog: React.FC<ToolCatalogProps> = ({
tools,
addTool,
removeTool,
}) => {
const ToolCatalog: React.FC<ToolCatalogProps> = ({ tools, addTool }) => {
const [url, setUrl] = useState('');
const [query, setQuery] = useState('');
const [searchResults, setSearchResults] = useState({} as ToolsSiteResponse);
Expand Down Expand Up @@ -478,11 +473,10 @@ const ToolCatalog: React.FC<ToolCatalogProps> = ({
startContent={
tools?.includes(repo) ? <GoCheck /> : <GoPlus />
}
disabled={tools?.includes(repo)}
color={tools?.includes(repo) ? 'success' : 'primary'}
onPress={() => {
if (tools?.includes(repo)) {
removeTool(repo);
} else {
if (!tools?.includes(repo)) {
addTool(repo);
}
}}
Expand Down Expand Up @@ -576,7 +570,6 @@ const ToolCatalog: React.FC<ToolCatalogProps> = ({
icon: <GoTools className="text-2xl" />,
});
} else {
removeTool(url);
priorityTools['From URL'] = priorityTools[
'From URL'
].filter((t) => t.url !== url);
Expand Down Expand Up @@ -621,16 +614,15 @@ const ToolCatalog: React.FC<ToolCatalogProps> = ({
isIconOnly
radius="full"
variant="flat"
disabled={tools?.includes(tool.url)}
startContent={
tools?.includes(tool.url) ? <GoCheck /> : <GoPlus />
}
color={
tools?.includes(tool.url) ? 'success' : 'primary'
}
onPress={() => {
if (tools?.includes(tool.url)) {
removeTool(tool.url);
} else {
if (!tools?.includes(tool.url)) {
addTool(tool.url);
}
}}
Expand Down
19 changes: 10 additions & 9 deletions components/edit/configure/imports/toolCatalogModal.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useState } from 'react';
import { useCallback, useState } from 'react';
import { Button, Modal, ModalBody, ModalContent } from '@nextui-org/react';
import { GoTools } from 'react-icons/go';
import ToolCatalog from '@/components/edit/configure/imports/toolCatalog';
Expand All @@ -7,16 +7,22 @@ import PropTypes from 'prop-types';
interface ToolCatalogModalProps {
tools: string[] | undefined;
addTool: (tool: string) => void;
removeTool: (tool: string) => void;
}

const ToolCatalogModal: React.FC<ToolCatalogModalProps> = ({
tools,
addTool,
removeTool,
}) => {
const [isModalOpen, setIsModalOpen] = useState(false);

const addToolAndClose = useCallback(
(tool: string) => {
setIsModalOpen(false);
addTool(tool);
},
[addTool, isModalOpen, setIsModalOpen]
);

return (
<>
<Button
Expand Down Expand Up @@ -44,11 +50,7 @@ const ToolCatalogModal: React.FC<ToolCatalogModalProps> = ({
>
<ModalContent>
<ModalBody>
<ToolCatalog
tools={tools}
addTool={addTool}
removeTool={removeTool}
/>
<ToolCatalog tools={tools} addTool={addToolAndClose} />
</ModalBody>
</ModalContent>
</Modal>
Expand All @@ -60,7 +62,6 @@ ToolCatalogModal.propTypes = {
// @ts-ignore
tools: PropTypes.arrayOf(PropTypes.string).isRequired,
addTool: PropTypes.func.isRequired,
removeTool: PropTypes.func.isRequired,
};

export default ToolCatalogModal;
Loading