fix: oom on long messages #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As currently implemented, this still has the socket disconnect problem. Signed-off-by: Donnie Adams <donnie@acorn.io>
njhale
force-pushed
the
fix-oom-on-long-messages-w-queue
branch
from
16b1087 to
facefe0
Compare
Offload the processing of progress events to a workequeue to free up resources for socket.io's heartbeat (i.e. ping/pong) to work. This prevents the page from refreshing on long running responses. Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
njhale
force-pushed
the
fix-oom-on-long-messages-w-queue
branch
from
facefe0 to
f6bafb1
Compare
njhale
requested review from
StrongMonkey,
thedadams,
g-linville,
ryanhopperlowe and
tylerslaton
…g interval Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
thedadams
previously approved these changes
Sep 6, 2024
tylerslaton
suggested changes
Sep 6, 2024
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
thedadams
reviewed
Sep 6, 2024
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
previously approved these changes
Sep 6, 2024
tylerslaton
approved these changes
Sep 6, 2024
tylerslaton
suggested changes
Sep 6, 2024
|
I'm seeing this behavior with Confirm calls, Prompt calls and general tool calls. Screen.Recording.2024-09-06.at.4.01.58.PM.mov |
Signed-off-by: Donnie Adams <donnie@acorn.io>
tylerslaton
approved these changes
Sep 6, 2024
cjellick
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #403