Enhance: Rework debug view #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Jellick <craig@acorn.io>
Signed-off-by: Craig Jellick <craig@acorn.io>
cjellick
requested review from
tylerslaton,
StrongMonkey,
thedadams,
ryanhopperlowe and
g-linville
ryanhopperlowe
previously approved these changes
Sep 17, 2024
| import { JSONTree } from 'react-json-tree'; | ||
|
|
||
| const CallFrames = ({ calls }: { calls: Record<string, CallFrame> | null }) => { | ||
| if (!calls) return null; |
There was a problem hiding this comment.
can you move this line to be placed right before the final return statement?
or add a TODO to do so?
There was a problem hiding this comment.
I dont follow. Isn't this a short-circuit, the point of which is to just quit this function early if calls is null/empty?
There was a problem hiding this comment.
spoke offline. i follow now
tylerslaton
previously approved these changes
Sep 17, 2024
|
Side note - when I tested this locally I saw a severity high issue in the npm audit. Will have a follow-up PR that patches that up. |
cjellick
dismissed stale reviews from tylerslaton and ryanhopperlowe
via
8571a85
tylerslaton
approved these changes
Sep 18, 2024
|
Ryan had approved, but wanted a TODO comment. I added that. I'm going to merge now just to close the loop here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Craig Jellick craig@acorn.io