Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use array and new pluralized name for credential overrides #43

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

njhale
Copy link
Member

@njhale njhale commented Jul 1, 2024

No description provided.

Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Copy link
Collaborator

@thedadams thedadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would you mind adding a test around this similar to the other SDKs?

@njhale
Copy link
Member Author

njhale commented Jul 1, 2024

nit: would you mind adding a test around this similar to the other SDKs?

@thedadams done. (sorry, must have missed it the first time around)

Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
@njhale njhale force-pushed the chore/update-cred-overrides branch from 2012ba3 to e1ccf96 Compare July 1, 2024 22:16
@njhale njhale merged commit a3474f4 into gptscript-ai:main Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants