Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElseIf statements are nested in an Else #537

Closed
robertleeplummerjr opened this issue Nov 26, 2019 · 0 comments
Closed

ElseIf statements are nested in an Else #537

robertleeplummerjr opened this issue Nov 26, 2019 · 0 comments
Assignees

Comments

@robertleeplummerjr
Copy link
Member

A GIF or MEME to give some spice of the internet

What is wrong?

Else if statements in both GPU and CPU look like this after they are transpiled:

else {
    if (statement) {
      // logic here
    }
}

I believe they should look like this:

else if (statement) {
  // logic here
}

Where does it happen?

How do we replicate the issue?

How important is this (1-5)?

2

Expected behavior (i.e. solution)

Other Comments

@robertleeplummerjr robertleeplummerjr self-assigned this Nov 26, 2019
robertleeplummerjr added a commit that referenced this issue Nov 26, 2019
ammyk9 pushed a commit to ammyk9/gpu.js that referenced this issue Aug 8, 2024
...it kind of snowballed from some needs
Fixes gpujs#521 - If `tactic` is not set, check precision allowed from WebGL, and automatically change based off needs, otherwise use value from `tactic`.
Fixes gpujs#535 - Internally check if texture from argument is the same as output, if so, clone this texture, and then clean it up after the kernel runs.
Fixes gpujs#536 - Normalize all declarations to non-destructured, and then parse
Fixes gpujs#537 - Change logic
Fixes gpujs#538 - Found the GL script that would work, and reduced the methods to use it
Fixes gpujs#539 - Found a better way of testing random, and this gives me an error for 1 in 10 runs, acceptable

Some refactoring for less duplicate code and documentation
ammyk9 pushed a commit to ammyk9/gpu.js that referenced this issue Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant