Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test texture-compression-bc-sliced-3d #3761

Open
mehmetoguzderin opened this issue May 26, 2024 · 8 comments · Fixed by #3762 or #3777
Open

Test texture-compression-bc-sliced-3d #3761

mehmetoguzderin opened this issue May 26, 2024 · 8 comments · Fixed by #3762 or #3777
Assignees

Comments

@mehmetoguzderin
Copy link
Member

mehmetoguzderin commented May 26, 2024

gpuweb/gpuweb#4705

webgpu:api,validation,texture,*, and also operation tests where applicable.

@kainino0x
Copy link
Collaborator

I think we also need to make sure we have basic sampling operation tests, as well as both validation and operation tests for copyTextureToTexture/TextureToBuffer/BufferToTexture and writeTexture.

@kainino0x kainino0x reopened this May 28, 2024
@mehmetoguzderin
Copy link
Member Author

@kainino0x Thank you very much for the guidance, I missed those aspects. I will follow-up with a PR for those tests, too! Appreciated!

@kainino0x
Copy link
Collaborator

@greggman since you just added 2d compressed texture sampling tests in #3760, would it make sense for you to do the sampling tests for 3d? It will probably fit into what you're already working on.

@greggman
Copy link
Contributor

Yes, sure. I can either do it now and they'll fail or we can add them later but the code will just be almost copy and pasted from the 2d stuff so unless I remove them they'll already kind of maybe do the right thing but fail until implemented.

mehmetoguzderin added a commit to mehmetoguzderin/cts that referenced this issue Jun 1, 2024
Partially fixes gpuweb#3761

Please let me know if I missed or overlooked anything. Your guidance would be appreciated. Thank you!
mehmetoguzderin added a commit to mehmetoguzderin/cts that referenced this issue Jun 1, 2024
Partially fixes gpuweb#3761

Please let me know if I missed or overlooked anything. Your guidance would be appreciated. Thank you!
mehmetoguzderin added a commit to mehmetoguzderin/cts that referenced this issue Jun 1, 2024
Partially fixes gpuweb#3761

Please let me know if I missed or overlooked anything. Your guidance would be appreciated. Thank you!
mehmetoguzderin added a commit that referenced this issue Jun 4, 2024
* Update validation tests for 3D textures with BC compression

Partially fixes #3761

Please let me know if I missed or overlooked anything. Your guidance would be appreciated. Thank you!

* Apply suggestions from code review

Co-authored-by: Kai Ninomiya <kainino1@gmail.com>

* Apply suggestions from code review

+@kainino0x

* Apply suggestions from code review

Co-authored-by: Kai Ninomiya <kainino1@gmail.com>

---------

Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
@mehmetoguzderin
Copy link
Member Author

Change needs to cover not only validation but also operation, reopening. Thank you.

@mehmetoguzderin
Copy link
Member Author

It seems like cb42984 actually fixed the additional limitation in util/texture/base, and there doesn't seem to be any additional particular filters to not test copies or writes of compressed 3D formats. I'll create a draft PR to dry run. Thank you!

@mehmetoguzderin mehmetoguzderin changed the title Update tests for 3D textures when format is compressed Test texture-compression-bc-sliced-3d Jul 25, 2024
@greggman
Copy link
Contributor

so fyi, the texture builtin tests should be able to test this stuff. Most of the exist tests just filter out compressed 3d (as slices) texture formats. If/when want to turn them on we just need to change the filters.

@mehmetoguzderin
Copy link
Member Author

@greggman thank you very much for the information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants