-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test texture-compression-bc-sliced-3d
#3761
Comments
I think we also need to make sure we have basic sampling operation tests, as well as both validation and operation tests for copyTextureToTexture/TextureToBuffer/BufferToTexture and writeTexture. |
@kainino0x Thank you very much for the guidance, I missed those aspects. I will follow-up with a PR for those tests, too! Appreciated! |
Yes, sure. I can either do it now and they'll fail or we can add them later but the code will just be almost copy and pasted from the 2d stuff so unless I remove them they'll already kind of maybe do the right thing but fail until implemented. |
Partially fixes gpuweb#3761 Please let me know if I missed or overlooked anything. Your guidance would be appreciated. Thank you!
Partially fixes gpuweb#3761 Please let me know if I missed or overlooked anything. Your guidance would be appreciated. Thank you!
Partially fixes gpuweb#3761 Please let me know if I missed or overlooked anything. Your guidance would be appreciated. Thank you!
* Update validation tests for 3D textures with BC compression Partially fixes #3761 Please let me know if I missed or overlooked anything. Your guidance would be appreciated. Thank you! * Apply suggestions from code review Co-authored-by: Kai Ninomiya <kainino1@gmail.com> * Apply suggestions from code review +@kainino0x * Apply suggestions from code review Co-authored-by: Kai Ninomiya <kainino1@gmail.com> --------- Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
Change needs to cover not only validation but also operation, reopening. Thank you. |
It seems like cb42984 actually fixed the additional limitation in util/texture/base, and there doesn't seem to be any additional particular filters to not test copies or writes of compressed 3D formats. I'll create a draft PR to dry run. Thank you! |
texture-compression-bc-sliced-3d
so fyi, the texture builtin tests should be able to test this stuff. Most of the exist tests just filter out compressed 3d (as slices) texture formats. If/when want to turn them on we just need to change the filters. |
@greggman thank you very much for the information. |
gpuweb/gpuweb#4705
webgpu:api,validation,texture,*
, and also operation tests where applicable.The text was updated successfully, but these errors were encountered: