Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't automatically include all types from dependencies #3704

Merged
merged 3 commits into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ module.exports = function (grunt) {
]);

registerTaskAndAddToHelp('serve', 'Serve out/ (without building anything)', ['run:serve']);
registerTaskAndAddToHelp('lint', 'Check lint and formatting', ['run:lint']);
registerTaskAndAddToHelp('fix', 'Fix lint and formatting', ['run:fix']);

addExistingTaskToHelp('clean', 'Delete built and generated files');
Expand Down
1 change: 0 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"checks": "grunt checks",
"unittest": "grunt unittest",
"typecheck": "grunt typecheck",
"lint": "grunt run:lint",
"fix": "grunt fix",
"gen_wpt_cts_html": "node tools/gen_wpt_cts_html",
"gen_cache": "node tools/gen_cache",
Expand Down Expand Up @@ -43,7 +44,6 @@
"@types/express": "^4.17.20",
"@types/jquery": "^3.5.25",
"@types/morgan": "^1.9.7",
"@types/node": "^20.8.10",
"@types/offscreencanvas": "^2019.7.2",
"@types/pngjs": "^6.0.3",
"@types/serve-index": "^1.9.3",
Expand Down
1 change: 1 addition & 0 deletions src/common/runtime/standalone.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Implements the standalone test runner (see also: /standalone/index.html).

/* eslint no-console: "off" */

import { dataCache } from '../framework/data_cache.js';
Expand Down
2 changes: 0 additions & 2 deletions src/common/util/navigator_gpu.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/// <reference types="@webgpu/types" />

import { TestCaseRecorder } from '../framework/fixture.js';

import { ErrorWithExtra, assert, objectEquals } from './util.js';
Expand Down
9 changes: 9 additions & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@
"compilerOptions": {
"lib": ["dom", "es2020"],
"module": "esnext",
// Use types only from these packages (not everything in package.json, which is the default).
// Note that TypeScript's `/// <reference />` is the same as adding an entry here - it's global
// to the whole project.
"types": [
"@types/dom-mediacapture-transform",
"@webgpu/types",
// Required for standalone.ts
"@types/jquery",
],
/* Output options */
"noEmit": true,
/* Strict type-checking options */
Expand Down
Loading