Add some tests for GPUCanvasContext getConfiguration #3973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaufortfrancois
force-pushed
the
getConfiguration
branch
from
9d9a458 to
b18e2e3
Compare
kainino0x
reviewed
Oct 1, 2024
|
@kainino0x I've fixed all ts errors. We should be good now. |
kainino0x
approved these changes
Oct 1, 2024
| @@ -459,8 +462,9 @@ g.test('viewFormats') | |||
| }, !compatible); | |||
|
|
|||
| const configuration = ctx.getConfiguration(); | |||
| t.expect(configuration.viewFormats?.length === 1); | |||
| t.expect(configuration.viewFormats[0] === viewFormat); | |||
| const viewFormats = Array.from(configuration!.viewFormats!); | |||
There was a problem hiding this comment.
non-blocking aside: Hm, we should actually change this in the types. The GPUCanvasConfiguration object that comes from getConfiguration() is guaranteed to have an array here (not any other kind of iterable). I'll make a PR.
There was a problem hiding this comment.
Once gpuweb/types#157 gets merged, I'll go fix the CTS. Thanks!
There was a problem hiding this comment.
@kainino0x Here's #3977
8 tasks
teoxoy
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Oct 25, 2024
teoxoy
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the GPUCanvasContext
getConfiguration()method that can be tested in Chromium patched with https://chromium-review.googlesource.com/c/chromium/src/+/5890176. It currently requires to run chromium with the experimental WebGPUExperimentalFeatures blink runtime feature (--enable-blink-features=WebGPUExperimentalFeatures). This is implied if you enable the "Unsafe WebGPU support" flag atchrome://flag#enable-unsafe-webgpu.Spec PR: gpuweb/gpuweb#4899
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.