Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add float32-blendable feature validation tests #4003

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

beaufortfrancois
Copy link
Collaborator

This PR adds "float32-blendable" feature validation tests to the CTS after it was added to the spec in gpuweb/gpuweb#4896.

It currently requires Chromium patched with https://dawn-review.googlesource.com/c/dawn/+/210754 and https://chromium-review.googlesource.com/c/chromium/src/+/5929023

image

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x enabled auto-merge (squash) October 16, 2024 04:12
@kainino0x kainino0x disabled auto-merge October 16, 2024 04:12
@kainino0x kainino0x enabled auto-merge (squash) October 16, 2024 04:13
@kainino0x kainino0x disabled auto-merge October 16, 2024 04:19
@kainino0x kainino0x enabled auto-merge (squash) October 16, 2024 04:19
@kainino0x kainino0x merged commit 85bd850 into main Oct 16, 2024
1 check passed
@kainino0x kainino0x deleted the float32-blendable branch October 16, 2024 04:22
@beaufortfrancois
Copy link
Collaborator Author

beaufortfrancois commented Oct 16, 2024 via email

teoxoy pushed a commit to mozilla/gpuweb-cts that referenced this pull request Oct 25, 2024
* Add float32-blendable feature validation tests

* apply suggestion

* roll types

---------

Co-authored-by: Kai Ninomiya <kainino@chromium.org>
teoxoy pushed a commit to mozilla/gpuweb-cts that referenced this pull request Oct 25, 2024
* Add float32-blendable feature validation tests

* apply suggestion

* roll types

---------

Co-authored-by: Kai Ninomiya <kainino@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants