Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: textureLoad + aspect for importExternalTexture #4052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kangz
Copy link
Collaborator

@Kangz Kangz commented Nov 20, 2024

Shaobo, is it expected that new files that are just scaled would fail to decode colors correctly? The other files pass all tests locally.

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@Kangz Kangz requested a review from shaoboyan November 20, 2024 17:36
@shaoboyan091
Copy link

(Sry for delay, just got my new github account)
I think scale shouldn't affect the result. After applying the PR and run the test, I'm a bit suspect this diff is due to the border (four color area) but not sure why this affect the final result. IIRC, some tests also fails due to this issue. A further investigation needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants