Skip to content

Conversation

@beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented Nov 28, 2025

I ran successfully those tests in Chromium patched with https://chromium-review.googlesource.com/c/chromium/src/+/7172047

image

Issue: #4509
Dawn issue: https://issues.chromium.org/issues/462468372


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@beaufortfrancois beaufortfrancois force-pushed the transient-attachments-operation-tests branch from 1fc47d7 to e6a13d9 Compare November 28, 2025 14:23
@beaufortfrancois beaufortfrancois marked this pull request as draft November 28, 2025 14:24
@beaufortfrancois beaufortfrancois force-pushed the transient-attachments-operation-tests branch from e6a13d9 to 8430c6f Compare December 3, 2025 14:22
@beaufortfrancois
Copy link
Collaborator Author

Hey Gregg, I'm starting to add some operation tests and would love an early review from you if that's okay.

Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the changes to copyTextureToTexture.spec.ts are appropriate. They aren't part of what's being tested, they're instead part of checking the actual test passed. It doesn't seem like a test param should be related to how the test is checked, only which test is being tested. wdyt?

For resolve. LGTM though it's distressing that only 1 format is tested (that doesn't have to be fixed in this PR).

@beaufortfrancois
Copy link
Collaborator Author

Thanks @greggman. I've reverted copyTextureToTexture changes and only kept operation tests for resolve.

@beaufortfrancois beaufortfrancois marked this pull request as ready for review December 4, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants