Improve TypeScript Types

[MunifTanjim]

Example Usage:

// Options type
type O = { [key: string]: any }

// return type
type R = number

const hook = new Singular<O, R>()

const hookMethod = async (options: O): Promise<R> => {
  return 42
}

hook(hookMethod, {})

---

With these changes, the following type definition here can be expressed as:

  hook: HookSingular<Octokit.HookOptions, Octokit.Response<any>, Octokit.HookError>

Edit: well, first it'll have to be changed to a singular hook ¯_(ツ)_/¯

---

resolves #61 (typings related issue)

[gr2m]

Hey Munif, thanks a lot for your help with Typescript!

I wonder if we could add a typescript test to make sure we don’t break it in future?

We have setup one like this here: https://github.com/octokit/rest.js/blob/master/test/typescript-validate.ts

[MunifTanjim]

@gr2m

We have setup one like this here: https://github.com/octokit/rest.js/blob/master/test/typescript-validate.ts

Of course. I'll add a test file like that with the PR.

[MunifTanjim]

@gr2m It's done!

[gr2m]

fantastic work 🥇 thank you so much!

Just one question

[gr2m]

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀