test: .defaults().defaults() (#58)

* test: `.defaults().defaults()` * refactor: simplify constructor implementation
gr2m · Jul 8, 2021 · 50341d7 · 50341d7
1 parent bd9d789
commit 50341d7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -16,8 +16,11 @@ export class Base {
   }
   static defaults(defaults) {
     return class extends this {
-      constructor(...args) {
-        super(Object.assign({}, defaults, args[0] || {}));
+      constructor(options) {
+        super({
+          ...defaults,
+          ...options,
+        });
       }
     };
   }

diff --git a/test/base.test.js b/test/base.test.js
@@ -36,6 +36,13 @@ test(".defaults({foo: 'bar'})", () => {
   assert.equal(defaultsTest.options, { foo: "bar" });
   assert.equal(mergedOptionsTest.options, { foo: "bar", baz: "daz" });
 });
+test(".defaults({one: 1}).defaults({two: 2})", () => {
+  const BaseWithDefaults = Base.defaults({ one: 1 }).defaults({ two: 2 });
+  const defaultsTest = new BaseWithDefaults();
+  const mergedOptionsTest = new BaseWithDefaults({ three: 3 });
+  assert.equal(defaultsTest.options, { one: 1, two: 2 });
+  assert.equal(mergedOptionsTest.options, { one: 1, two: 2, three: 3 });
+});
 
 test(".plugin().defaults()", () => {
   const BaseWithPluginAndDefaults = Base.plugin(fooPlugin).defaults({