feat: inher constructor options via Base.defaults()

gr2m · Jun 18, 2021 · bf15c10 · bf15c10
1 parent 4c8cec9
commit bf15c10
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -1,7 +1,8 @@
 export declare namespace Base {
-  type Options = {
+  interface Options {
+    version: string;
     [key: string]: unknown;
-  };
+  }
 }
 
 declare type ApiExtension = {
@@ -56,7 +57,7 @@ export declare class Base<TOptions extends Base.Options = Base.Options> {
       options: TDefaults;
     };
   } & S;
-  constructor(options?: TOptions);
+  constructor(options: TOptions);
   options: TOptions;
 }
 export {};
diff --git a/index.test-d.ts b/index.test-d.ts
@@ -5,13 +5,16 @@ import { fooPlugin } from "./plugins/foo/index.js";
 import { barPlugin } from "./plugins/bar/index.js";
 import { voidPlugin } from "./plugins/void/index.js";
 
-const base = new Base();
+const base = new Base({
+  version: "1.2.3",
+});
 
 // @ts-expect-error unknown properties cannot be used, see #31
 base.unknown;
 
 const FooBase = Base.plugin(fooPlugin).defaults({
   default: "value",
+  version: "1.2.3",
 });
 const fooBase = new FooBase({
   option: "value",
@@ -22,13 +25,17 @@ expectType<string>(fooBase.options.option);
 expectType<string>(fooBase.foo);
 
 const BaseWithVoidPlugin = Base.plugin(voidPlugin);
-const baseWithVoidPlugin = new BaseWithVoidPlugin();
+const baseWithVoidPlugin = new BaseWithVoidPlugin({
+  version: "1.2.3",
+});
 
 // @ts-expect-error unknown properties cannot be used, see #31
 baseWithVoidPlugin.unknown;
 
 const BaseWithFooAndBarPlugins = Base.plugin(barPlugin, fooPlugin);
-const baseWithFooAndBarPlugins = new BaseWithFooAndBarPlugins();
+const baseWithFooAndBarPlugins = new BaseWithFooAndBarPlugins({
+  version: "1.2.3",
+});
 
 expectType<string>(baseWithFooAndBarPlugins.foo);
 expectType<string>(baseWithFooAndBarPlugins.bar);
@@ -41,7 +48,9 @@ const BaseWithVoidAndNonVoidPlugins = Base.plugin(
   voidPlugin,
   fooPlugin
 );
-const baseWithVoidAndNonVoidPlugins = new BaseWithVoidAndNonVoidPlugins();
+const baseWithVoidAndNonVoidPlugins = new BaseWithVoidAndNonVoidPlugins({
+  version: "1.2.3",
+});
 
 expectType<string>(baseWithVoidAndNonVoidPlugins.foo);
 expectType<string>(baseWithVoidAndNonVoidPlugins.bar);