Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required version option, implement required constructor options dynamically based on Base.Options interface #60

Closed
gr2m opened this issue Jul 17, 2021 · 1 comment · Fixed by #63
Assignees
Labels

Comments

@gr2m
Copy link
Owner

gr2m commented Jul 17, 2021

This is a follow up to #57 (comment)

I think what I'd suggest we do is to add a new use-cases folder, and in that folder create required-options with index.js, index.d.ts and index.test-d.ts files.

In /use-cases/required-options/index.d.ts we would define a required option by extending the Base.Options interface and then add tests to index.test-d.ts to make sure the types work correctly with the new Base(options) constructor and with .defaults(options) calls

@github-actions
Copy link

🎉 This issue has been resolved in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant