Backport of GR-52940: Fix reported values in GCHeapSummary JFR event #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
The gate errors seem to be caused by truffle related things seemingly unrelated to this change. |
zakkak
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Hi @roberttoyonaga,
Can you please use git cherry-pick -x for the backport and also include oracle/graal@83b936a from oracle/graal#8653?
Thank you
roberttoyonaga
force-pushed
the
GR-52940
branch
from
4fe0166 to
72c0a91
Compare
|
Ok I've used I also needed to add some proxy configuration to the tests. This config exists in GraalVM, but not in this backport repository. |
zakkak
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
LGTM, thanks @roberttoyonaga.
FYI I rebased it on latest master and will merge once the CI runs complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor backport of oracle/graal#8653 to correct some values in the JFR GCHeapSummary event.
Low risk because it only modifies hard coded values and adds test code.
Tested with
mx native-unittest: passed.