Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-55243] [GR-56816] [GR-56859] [GR-56863] [GR-56861] [GR-56855] [GR-56883] Backport to 23.1: Improve serial GC heap verification and other GC-related changes. #38

Closed
wants to merge 10 commits into from

Conversation

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

  • PR author: luneo7

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jan 22, 2025
@jerboaa
Copy link
Contributor

jerboaa commented Jan 22, 2025

This is probably best merged after the 23.1.6 update is tagged.

@luneo7
Copy link
Author

luneo7 commented Jan 22, 2025

Yeah, also singed the OCA, just waiting for verification

Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jan 23, 2025
@zakkak
Copy link
Contributor

zakkak commented Jan 23, 2025

@luneo7 thank you for the contribution.

Since we plan to backport all changes from vm-23.1.5 I created #41 which brings all the changes in one go.
Unfortunately the OCA job says that "OCA check failed due to more than 250 commits in PR" so we might end up needing to break it in more PRs (will have to check with the GraalVM team).

In any case, since vm-23.1.5 contains ~600 more commits than this repository I don't think it is viable to do one backport per bug/feature which we would normally do like you do in this PR. As a result I am going to close this PR in favor of #41 or the potential smaller ones (still in batches) that we will need to create.

If anything changes I will re-open this. Thanks again.

@zakkak zakkak closed this Jan 23, 2025
@zakkak
Copy link
Contributor

zakkak commented Feb 18, 2025

Hi @luneo7 , if you are still interested in contributing backports you can have a look at #37. Just comment in that issue if you plan to work on one of the patch batches to avoid duplicating effort. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants