Implements automated release to SDKMAN #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Karm
commented
Mar 17, 2022
Karm
commented
```
$ ./mandrel-release.java sdkman -m /home/karm/workspaceRH/graal/graal -s Final -f Karm/graal
[jbang] Building jar...
[INFO] Current version is 21.3.1.1
[INFO] New version will be 21.3.1.2
[INFO] Releasing: mandrel-java11-linux-amd64-21.3.1.1-Final.tar.gz
[INFO] Released Response Code : 201
[INFO] Released Response Body : {"message":"Released: java 21.3.1.1.r11-mandrel for LINUX_64","status":201}
[INFO] Releasing: mandrel-java11-linux-aarch64-21.3.1.1-Final.tar.gz
[INFO] Released Response Code : 201
[INFO] Released Response Body : {"message":"Released: java 21.3.1.1.r11-mandrel for LINUX_ARM64","status":201}
[INFO] Releasing: mandrel-java11-windows-amd64-21.3.1.1-Final.zip
[INFO] Released Response Code : 201
[INFO] Released Response Body : {"message":"Released: java 21.3.1.1.r11-mandrel for WINDOWS_64","status":201}
[INFO] Releasing: mandrel-java17-linux-amd64-21.3.1.1-Final.tar.gz
[INFO] Released Response Code : 201
[INFO] Released Response Body : {"message":"Released: java 21.3.1.1.r17-mandrel for LINUX_64","status":201}
[INFO] Releasing: mandrel-java17-linux-aarch64-21.3.1.1-Final.tar.gz
[INFO] Released Response Code : 201
[INFO] Released Response Body : {"message":"Released: java 21.3.1.1.r17-mandrel for LINUX_ARM64","status":201}
[INFO] Releasing: mandrel-java17-windows-amd64-21.3.1.1-Final.zip
[INFO] Released Response Code : 201
[INFO] Released Response Body : {"message":"Released: java 21.3.1.1.r17-mandrel for WINDOWS_64","status":201}
[INFO] Promoting version 21.3.1.1.r11
[INFO] Promoted Response Code : 202
[INFO] Promoted Response Body : {"message":"Defaulted: java 21.3.1.1.r11-mandrel","status":202}
[INFO] Annoncing version 21.3.1.1.r11
[INFO] Annonce Response Code : 200
[INFO] Annonce Response Body : {"status":200,"id":"623342f06344590007b7da9c","message":"java 21.3.1.1.r11-mandrel available on SDKMAN! https://github.com/graalvm/mandrel/releases/"}
[INFO] Promoting version 21.3.1.1.r17
[INFO] Promoted Response Code : 202
[INFO] Promoted Response Body : {"message":"Defaulted: java 21.3.1.1.r17-mandrel","status":202}
[INFO] Annoncing version 21.3.1.1.r17
[INFO] Annonce Response Code : 200
[INFO] Annonce Response Body : {"status":200,"id":"623342f16344590007b7da9d","message":"java 21.3.1.1.r17-mandrel available on SDKMAN! https://github.com/graalvm/mandrel/releases/"}
```
|
@zakkak IMHO implemented. The release is visible on sdkman, but, I cannot verify it atm: The reason it GitHub is mostly down: https://www.githubstatus.com/ So let's try to check it later.... |
|
Hmm, not sure what is wrong. And we are also used in the docs as the default Java. Probably because we are the latest release...? Older ones work just fine: The one published by this automation doesn't: I am not sure what could be wrong. It's seems to be really fool proof, e.g. my tested payload: |
zakkak
reviewed
Mar 18, 2022
|
|
||
| /** | ||
| * One needs vendor credentials. Decipher those in: | ||
| * gpg --decrypt sdkman-vendor.json.asc > ~/.sdkman/vendor.json |
There was a problem hiding this comment.
It would possibly be even better if we could get the script to do the decrypt on the fly.
There was a problem hiding this comment.
Will this be run on one of your local machines? The only reason I sent the credentials encrypted was that we don't like sending credentials in an email.
On the other hand, if this is an automated release script, please consider storing the key and token pair in GitHub secrets instead.
There was a problem hiding this comment.
Will this be run on one of your local machines?
Yes, this will be run locally. So it's more about whether we would need to have the credentials stored in an unencrypted file (most probably on an encrypt disk though).
There was a problem hiding this comment.
It is a local workstation with an exclusive physical access and an encrypted drive. The file enjoys the same level of security, including filesystem permissions, as e.g. ~/.aws/credentials or, for the matter of fact, ~/.ssh/id_rsa.
|
Setting Notice the My suspicion is that you "published" the new version while github was down and that somehow messed up the sdkman database update for the new version. |
zakkak
reviewed
Mar 18, 2022
|
@zakkak debug & dryRun: |
|
TL;DR from our conversation with Marco:
|
|
FWIW JReleaser can perform most of thew heavy lifting you're doing with the |
|
Hello @marc0der, Taking your recommendation about @zakkak
|
|
@marc0der ...or we can drop the topic and wait for DISCO 😃 |
|
Well, DISCO integration is already fully operational (we performed the JDK 18 release with this new mechanism yesterday). I'd suggest just rolling with that instead. @eddumelendez can pick it up if you like. I believe that all he needs to do is to add a few lines of config for this to start working. |
|
Merging as per our conversation on SDKMAN Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.