-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport reflection registration fix for JFR eventHandler fields #281
Conversation
FTR (and for linking the GH PRs) the corresponding upstream PR was oracle#3662 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the whole PR (oracle#3662) backported, i.e., I would prefer to see 7496416 and e7476d8 backported as well. WDYT?
Yes, I'd like to see those as well. e7476d8 has a meaningful change. |
Thanks for the reviews! I'll fix. Sigh. Working with Graal VM is a bit of a mess. So you really need to be looking at each and every PR to get the right commits? Wow. I guess squashing of commits makes more sense in this model. Looking at the Git logs it doesn't seem to be the upstream style, though... |
Well, trade offs :) Thanks for the backport Severin! |
Backports: oracle@bdaf8c2
Fix reflection registration for JFR eventHandler fields
Closes #270