Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport reflection registration fix for JFR eventHandler fields #281

Merged
merged 3 commits into from
Aug 17, 2021

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Aug 16, 2021

Backports: oracle@bdaf8c2

Fix reflection registration for JFR eventHandler fields
Closes #270

@zakkak zakkak requested a review from jiekang August 17, 2021 09:53
@zakkak
Copy link
Collaborator

zakkak commented Aug 17, 2021

FTR (and for linking the GH PRs) the corresponding upstream PR was oracle#3662

Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the whole PR (oracle#3662) backported, i.e., I would prefer to see 7496416 and e7476d8 backported as well. WDYT?

@zakkak zakkak added this to the 21.2.0.1-Final milestone Aug 17, 2021
@jiekang
Copy link
Collaborator

jiekang commented Aug 17, 2021

I would prefer the whole PR (oracle#3662) backported, i.e., I would prefer to see 7496416 and e7476d8 backported as well. WDYT?

Yes, I'd like to see those as well. e7476d8 has a meaningful change.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Aug 17, 2021

Thanks for the reviews! I'll fix.

Sigh. Working with Graal VM is a bit of a mess. So you really need to be looking at each and every PR to get the right commits? Wow. I guess squashing of commits makes more sense in this model. Looking at the Git logs it doesn't seem to be the upstream style, though...

@zakkak
Copy link
Collaborator

zakkak commented Aug 17, 2021

Sigh. Working with Graal VM is a bit of a mess. So you really need to be looking at each and every PR to get the right commits? Wow. I guess squashing of commits makes more sense in this model. Looking at the Git logs it doesn't seem to be the upstream style, though...

Well, trade offs :)

Thanks for the backport Severin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants