Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement annotation support for RecordComponents #360

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Implement annotation support for RecordComponents #360

merged 1 commit into from
Mar 1, 2022

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Feb 28, 2022

Fix for oracle#3984 till it gets merged upstream.

@zakkak zakkak added bug Something isn't working pending upstream Issue or PR pending action on upstream repository (oracle/graal) affects/JDK17 JDK17 related affects/21.3 labels Feb 28, 2022
@zakkak zakkak requested a review from jerboaa February 28, 2022 13:17
@zakkak
Copy link
Collaborator Author

zakkak commented Feb 28, 2022

@jerboaa I tested this locally and seems to work as expected. I am going to merge it once CI is done if things look like before :)

@jerboaa
Copy link
Collaborator

jerboaa commented Feb 28, 2022

@jerboaa I tested this locally and seems to work as expected. I am going to merge it once CI is done if things look like before :)

Sounds good. Looks like Windows build issues are unrelated.

@jerboaa
Copy link
Collaborator

jerboaa commented Feb 28, 2022

Thanks for doing this!

@zakkak
Copy link
Collaborator Author

zakkak commented Mar 1, 2022 •
edited
Loading

Sounds good. Looks like Windows build issues are unrelated.

Correct, #361 should take care of those.

@zakkak zakkak merged commit aac4af0 into graalvm:mandrel/21.3 Mar 1, 2022
@zakkak zakkak added this to the 21.3.1.1-Final milestone Mar 2, 2022
@zakkak zakkak added the release/noteworthy-feature A PR that is worth highlighting in the Changelog label Mar 2, 2022
@Karm Karm mentioned this pull request Mar 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa Awaiting requested review from jerboaa

Assignees
No one assigned
Labels
affects/JDK17 JDK17 related affects/21.3 bug Something isn't working pending upstream Issue or PR pending action on upstream repository (oracle/graal) release/noteworthy-feature A PR that is worth highlighting in the Changelog
Projects
None yet
Milestone
21.3.1.1-Final
Development

Successfully merging this pull request may close these issues.
2 participants
@zakkak @jerboaa