Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only require libmanagement_ext if it's actually needed. #444

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Oct 18, 2022

On some systems/apps, libawt_headless gets pulled in. This currently brings in libmanagement_ext unconditionally. However, libmanagement_ext should only be present for linking iff
com.sun.management.internal.OperatingSystemImpl class becomes reachable.

Backports: oracle#5122
Closes: #437

On some systems/apps, libawt_headless gets pulled in. This currently
brings in libmanagement_ext unconditionally. However, libmanagement_ext
should only be present for linking iff
com.sun.management.internal.OperatingSystemImpl class becomes reachable.

Closes: oracle#5119
@zakkak zakkak added bug Something isn't working backport labels Oct 18, 2022
@zakkak zakkak added this to the 22.3.0.1-Final milestone Oct 18, 2022
@zakkak zakkak requested a review from jerboaa October 18, 2022 08:51
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 18, 2022
@jerboaa jerboaa linked an issue Oct 18, 2022 that may be closed by this pull request
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 18, 2022

The following mandrel IT test failure should be fixed with #445:

 Error:    DebugSymbolsTest.debugSymbolsSmokeGDB:137->carryOutGDBSession:388 There were errors in the GDB session. Note that commands in the session might depend on each other. Errors: 
Command 'info functions .*smoke.*' did not match the expected pattern '.*File debug_symbols_smoke/ClassA.java:.*java.lang.String \*debug_symbols_smoke.ClassA::toString\(\).*File debug_symbols_smoke/Main.java:.*void debug_symbols_smoke.Main\$\$Lambda\$.*::accept\(java.lang.Object\*\).*void debug_symbols_smoke.Main::lambda\$thisIsTheEnd\$0\(java.io.ByteArrayOutputStream\*, debug_symbols_smoke.ClassA\*\).*void debug_symbols_smoke.Main::main\(java.lang.String\[\]\*\).*void debug_symbols_smoke.Main::thisIsTheEnd\(java.util.List\*\).*'.
Output was:
(gdb) All functions matching regular expression ".*smoke.*":

File debug_symbols_smoke/ClassA.java:
37:	java.lang.String *debug_symbols_smoke.ClassA::toString(debug_symbols_smoke.ClassA *);

File debug_symbols_smoke/Main.java:
	
    void debug_symbols_smoke.Main$$Lambda$720/0x00000007c07e8418::accept(debug_symbols_smoke.Main$$Lambda$720/0x00000007c07e8418 *, java.lang.Object *);
50:	
    void debug_symbols_smoke.Main::lambda$thisIsTheEnd$0(java.io.ByteArrayOutputStream *, debug_symbols_smoke.ClassA *);
64:	void debug_symbols_smoke.Main::main(java.lang.String[] *);
49:	void debug_symbols_smoke.Main::thisIsTheEnd(java.util.List *);
 ==> expected: <true> but was: <false>
[INFO] 
Error:  Tests run: 18, Failures: 1, Errors: 0, Skipped: 5

@zakkak zakkak merged commit 6088712 into graalvm:mandrel/22.3 Oct 18, 2022
@zakkak zakkak deleted the 2022-10-18-backport-5122 branch October 18, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider backporting Imageio/management_ext.a fix to 22.3
2 participants