Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Enable non time sensitive performance regression checks #582

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Oct 4, 2023

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 4, 2023
@zakkak zakkak force-pushed the 2023-10-04-enable-perf-regression branch 2 times, most recently from 031c19b to 3720003 Compare October 4, 2023 07:18
@zakkak
Copy link
Collaborator Author

zakkak commented Oct 4, 2023

@zakkak
Copy link
Collaborator Author

zakkak commented Oct 4, 2023

Windows job "Q main M 23.1 windows" fails with:

Application QUARKUS_FULL_MICROPROFILE in mode none executable size  is 76532 kB, which is over 75000 kB threshold by 2%.
 ==> expected: <true> but was: <false>
	at org.graalvm.tests.integration.RuntimesSmokeTest.testRuntime(RuntimesSmokeTest.java:162)
	at org.graalvm.tests.integration.RuntimesSmokeTest.quarkusFullMicroProfile(RuntimesSmokeTest.java:192)

@Karm do you see this in your 23.1 runs as well?

Copy link

github-actions bot commented Nov 4, 2023

This PR appears to be stale because it has been open 30 days with no activity. This PR will be closed in 7 days unless Stale label is removed, a new comment is made, or not-Stale label is added.

@github-actions github-actions bot added the Stale label Nov 4, 2023
@zakkak zakkak added not-Stale and removed Stale labels Nov 6, 2023
@zakkak
Copy link
Collaborator Author

zakkak commented Nov 6, 2023

@Karm do you see this in your 23.1 runs as well?

@Karm can you please have a look at this?

@zakkak zakkak force-pushed the 2023-10-04-enable-perf-regression branch 2 times, most recently from f411bfd to 9088184 Compare November 13, 2023 07:21
@zakkak
Copy link
Collaborator Author

zakkak commented Nov 13, 2023

@Karm Karm self-requested a review November 15, 2023 08:58
@Karm
Copy link
Collaborator

Karm commented Nov 15, 2023

@zakkak Loading context...

@Karm
Copy link
Collaborator

Karm commented Nov 16, 2023

@zakkak

Linux amd64

Quarkus Mandrel Executable size
3.1.3.Final java17-22.3.4.0-Final 68053 Kb
2.7.7.Final java17-21.3.6.0-Final 68558 Kb
3.4.3 java17-23.0.2.1-Final 71954 Kb
3.5.1 java21-23.1.1.0-Final 76647 Kb

Linux aarch64

Quarkus Mandrel Executable size
3.1.3.Final java17-22.3.4.0-Final 68525 Kb
2.7.7.Final java17-21.3.6.0-Final 68075 Kb
3.4.3 java17-23.0.2.1-Final 70063 Kb
3.5.1 java21-23.1.1.0-Final 74159 Kb

Windows amd64

Quarkus Mandrel Executable size
3.1.3.Final java17-22.3.4.0-Final 68780 Kb
2.7.7.Final java17-21.3.6.0-Final 70562 Kb
3.4.3 java17-23.0.2.1-Final 72760 Kb
3.5.1 java21-23.1.1.0-Final 76652 Kb

I think this is sane and what we've got now.

@zakkak zakkak force-pushed the 2023-10-04-enable-perf-regression branch from 9088184 to b70f05d Compare November 21, 2023 12:47
@zakkak
Copy link
Collaborator Author

zakkak commented Nov 21, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-Stale OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants