Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.3] Stop deleting (Buddhist|JapaneseImperial)Calendar #616

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Nov 13, 2023

This breaks basic Calendar.Builder semantics in native-images

Backport of:
oracle#6089

Tested with the test from Karm/mandrel-integration-tests#221 and should close quarkusio/quarkus#36975 (i.e. fix the native IT tests of graphql and quarkus main).

This breaks basic Calendar.Builder semantics in native-images

Backport of:
oracle#6089
@jerboaa
Copy link
Collaborator Author

jerboaa commented Nov 13, 2023

Mandrel IT test failure is Karm/mandrel-integration-tests#220

Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jerboaa

@jerboaa
Copy link
Collaborator Author

jerboaa commented Nov 13, 2023

FTR: graphql-client quarkus native tests now pass: https://github.com/graalvm/mandrel/actions/runs/6850917970/job/18628182074?pr=616#step:12:1286

I'll wait for the rest of the CI tests to complete and will then merge.

@jerboaa jerboaa merged commit 6e1462f into graalvm:mandrel/22.3 Nov 13, 2023
139 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants