Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22.3] Backports for January CPU release #638

Merged
merged 6 commits into from
Dec 18, 2023
Merged

[22.3] Backports for January CPU release #638

merged 6 commits into from
Dec 18, 2023

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Dec 18, 2023

Closes #605
Closes #619

zakkak and others added 6 commits December 18, 2023 12:15
@zakkak
Use synchronized data structures for reachability handlers registration
c629840 
Prevent data races in reachability handlers registration when using
`-H:-RunReachabilityHandlersConcurrently`.

Closes oracle#5868

(cherry picked from commit 777cb82)
@zakkak
Throw exception for null in RuntimeJNIAccess/RuntimeReflection reg.
08c1d09 
Don't allow null values to be passed to the `register` method of
`RuntimeJNIAccess` and `RuntimeReflection`. Since these are public APIs
GraalVM should either handle null values (by ignoring them in this case)
or throw a `NullPointerException` before creating an asynchronous task
to perform the registration in the analysis, which then results in
`NullPointerException`s being thrown later when it's no longer possible
to understand where the null value originate from.

(cherry picked from commit e6c12dd)
@fniephaus @zakkak
Fix style.
2f90e1a 
(cherry picked from commit d621dbd)
@fniephaus @zakkak
Move null checks to the beginning of register methods.
158239a 
Not before the register methods, which can miss cases, nor later on in a runnable.

(cherry picked from commit f94551a)
@fniephaus @zakkak
Apply non-null strategy to JNIAccessFeature.
cdc404c 
(cherry picked from commit d996f32)
@fniephaus @zakkak
Use Objects.requireNonNull() in ConditionalConfigurationRegistry.
88fcde3 
(cherry picked from commit 0ba6cc2)
@zakkak zakkak added this to the 22.3.5.0-Final milestone Dec 18, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 18, 2023
This was linked to issues Dec 18, 2023
[22.3] Backport: Throw exception for null pointers passed to RuntimeJNIAccess / RuntimeReflection register methods #605
Closed
[22.3] Backport: Synchronize accesses to reachability handlers #619
Closed
@zakkak zakkak requested a review from jerboaa December 18, 2023 11:08
jerboaa
jerboaa approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Having them in different PRs would make reviewing those easier.

@jerboaa
Copy link
Collaborator

jerboaa commented Dec 18, 2023

main integration test failure is: quarkusio/quarkus#37809

@zakkak
Copy link
Collaborator Author

zakkak commented Dec 18, 2023

Seems OK. Having them in different PRs would make reviewing those easier.

Noted.

@zakkak zakkak merged commit 2c0293f into graalvm:mandrel/22.3 Dec 18, 2023
132 of 133 checks passed
@zakkak zakkak deleted the 2023-12-18-22.3-jan-cpu-backports branch December 18, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa approved these changes

Assignees
No one assigned
Labels
affects/22.3 backport OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
22.3.5.0-Final
3 participants
@zakkak @jerboaa @fniephaus