[CI] Don't update file while reading it #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern is 'cat <<< $(echo < input-file.txt) > input-file.txt' which makes no guarantee that the input file isn't being clobbered while we still being read. Fix it by creating a temporary copy.
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Should fix issues we see in CI recently like: https://github.com/graalvm/mandrel/actions/runs/7247202176/job/19741559198?pr=638 |
zakkak
approved these changes
Dec 18, 2023
This was referenced Dec 18, 2023
zakkak
added a commit
to zakkak/mandrel
that referenced
this pull request
Dec 18, 2023
Follow up to graalvm#641 Closes graalvm#642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern is
cat <<< $(echo < input-file.txt) > input-file.txtwhich makes no guarantee that the input file,input-file.txt, isn't being clobbered while still being read by the subshell. Fix it by creating a temporary copy.