Fix for birth time support #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
jerboaa
changed the title
|
Looks like we need a few fixes after this:
|
zakkak
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
LGTM
This is a partial backport of oracle/graal@5a8a6ec
It avoids the JDK version specific conditional as this new JNI registration is only needed for JDKs having the sun.nio.fs.UnixFileAttributes.st_birthtime_nsec field new with JDK-8316304-carrying base JDKs.
|
FTR the upstream backport is graalvm/graalvm-for-jdk17-community-backports@5d9bcac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also posted this in https://github.com/graalvm/graalvm-for-jdk17-community-backports. However, in order to get to a cleaner state in prep of the
23.0.4release in April, I'd like to see this merged and we can then re-arrange with upstream. There seem to be follow on fixes we need to do already (see comments below).We have our weekly CI in pretty bad shape because of this. See for example:
https://github.com/graalvm/mandrel/actions/runs/8027152295/job/21931252548#step:12:254