Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action installs Oracle GraalVM on top of Mandrel #54

Closed
nscuro opened this issue Aug 1, 2023 · 6 comments
Closed

Action installs Oracle GraalVM on top of Mandrel #54

nscuro opened this issue Aug 1, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@nscuro
Copy link

nscuro commented Aug 1, 2023

The action appears to install the Oracle GraalVM distribution on top of Mandrel, when only Mandrel is configured.

Example build output:

Run graalvm/setup-graalvm@v1
  with:
    distribution: mandrel
    version: mandrel-latest
    java-version: 17
    components: native-image
    github-token: ***
    set-java-home: true
    check-for-updates: true
    native-image-musl: false
    native-image-job-reports: false
    native-image-pr-reports: false
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.7-7/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.7-7/x64
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/3297c16a-6e0c-4d7f-85f3-8aea9897056d -f /home/runner/work/_temp/9a492745-e727-4331-a37f-0a5e6fbdd33e
Adding mandrel-java17-linux 23.0.1.2-Final to tool-cache ...
This build is using the new Oracle GraalVM. To select a specific distribution, use the 'distribution' option (see https://github.com/graalvm/setup-graalvm/tree/main#options).
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/a3b4128c-fd4c-4154-ac03-666871ca017c -f /home/runner/work/_temp/f19211d5-e943-476b-960a-ccc00e42e5c2
Adding graalvm-jdk-17_linux-x64_bin 17 to tool-cache ...
Warning: Mandrel does not support GraalVM components: native-image

It correctly detects that Mandrel was requested (Adding mandrel-java17-linux 23.0.1.2-Final to tool-cache ...), but then proceeds to install Oracle GraalVM (This build is using the new Oracle GraalVM).

Later build steps (here with Quarkus) then report:

[INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] Running Quarkus native-image plugin on native-image 17.0.8 2023-07-18
GraalVM Runtime Environment Oracle GraalVM 17.0.8+9.1 (build 17.0.8+9-LTS-jvmci-23.0-b14)
Substrate VM Oracle GraalVM 17.0.8+9.1 (build 17.0.8+9-LTS, serial gc, compressed references)
@fniephaus fniephaus self-assigned this Aug 1, 2023
@fniephaus fniephaus added the bug Something isn't working label Aug 1, 2023
@fniephaus
Copy link
Member

Hi @nscuro, thanks for the report. Could you share a link to a failing build please?

@nscuro
Copy link
Author

nscuro commented Aug 1, 2023

@fniephaus
Copy link
Member

I think I tracked it down, please restart your build and let me know whether this is fixed now.

@nscuro
Copy link
Author

nscuro commented Aug 1, 2023

Thanks for the light speed fix! 🚀

Will give it a spin and report back.

@nscuro
Copy link
Author

nscuro commented Aug 1, 2023

That did it, can confirm: https://github.com/DependencyTrack/hyades/actions/runs/5726712395/job/15517701393?pr=713

Thanks again for addressing it so quickly!

nscuro added a commit to DependencyTrack/hyades that referenced this issue Aug 1, 2023
Previous issue with installing Mandrel via GitHub Actions has been resolved, see graalvm/setup-graalvm#54

Signed-off-by: nscuro <nscuro@protonmail.com>
@fniephaus
Copy link
Member

Great! Thanks for confirming...and happy building!

mehab pushed a commit to DependencyTrack/hyades that referenced this issue Sep 12, 2023
Previous issue with installing Mandrel via GitHub Actions has been resolved, see graalvm/setup-graalvm#54

Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: mehab <meha.bhargava@citi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants