Add support for Rust test cases #817
Conversation
anatol1234
force-pushed
the
rust_testcase_support
branch
3 times, most recently
from
e7861c4 to
2e8fb70
Compare
mx.sulong/suite.py
Outdated
| @@ -388,6 +397,7 @@ | |||
| "com.oracle.truffle.llvm.tests.nfi", | |||
| "com.oracle.truffle.llvm.tests.sulong", | |||
| "com.oracle.truffle.llvm.tests.sulongcpp", | |||
| "com.oracle.truffle.llvm.tests.sulongrust", | |||
anatol1234
force-pushed
the
rust_testcase_support
branch
from
e5feb38 to
4890a85
Compare
anatol1234
force-pushed
the
rust_testcase_support
branch
7 times, most recently
from
82c9498 to
075ba98
Compare
.travis.yml
Outdated
| @@ -79,7 +82,7 @@ matrix: | |||
| jdk: oraclejdk8 | |||
| - env: GATE_TAGS='gcc_cpp' COMPILE_COMMAND='mx build --dependencies SULONG_TEST' | |||
| jdk: oraclejdk8 | |||
| - env: DOWNSTREAM_REPO='https://github.com/graalvm/graal.git' DOWNSTREAM_SUITE='substratevm' DOWNSTREAM_COMMAND='--dynamicimport sulong gate --tags build,sulong' | |||
| - env: DOWNSTREAM_REPO='https://github.com/graalvm/graal.git' DOWNSTREAM_SUITE='substratevm' DOWNSTREAM_COMMAND='--dynamicimport sulong gate --tags build,sulong' SULONG_USE_RUSTC='false' | |||
There was a problem hiding this comment.
Why does it not work with substratevm? I think we should rather fix the bug than disable the test.
If it doesn't work with substratevm, it also won't work in the default configuration of the graalvm distribution.
There was a problem hiding this comment.
The problem is that somewhere the Rust standard library needs to be linked. I configure this in mx_sulong. Does graal dodge the _unittest_config_participant hook in the default configuration?
There was a problem hiding this comment.
That's probably a problem with the test harness then. I guess the arguments are not being forwarded correctly between the VM running the test harness and the Sulong VM. I'll take a look at that.
There was a problem hiding this comment.
Forwarding of arguments has been functioning now for a while. I configured the arguments in testLLVMImage and reactivated Rust for the graalvm gate (formerly substratevm gate).
The changes revolving around LLVMGlobal broke support for the recent Rust versions depending on @std::rt::lang_start_internal. I fixed the intrinsic accordingly and added a gate check for Rust 1.27.1.
anatol1234
force-pushed
the
rust_testcase_support
branch
from
075ba98 to
b2f0cfc
Compare
anatol1234
force-pushed
the
rust_testcase_support
branch
12 times, most recently
from
644003a to
1c4c323
Compare
anatol1234
force-pushed
the
rust_testcase_support
branch
from
1c4c323 to
da895f1
Compare
anatol1234
force-pushed
the
rust_testcase_support
branch
from
5f0855c to
55f1572
Compare
anatol1234
force-pushed
the
rust_testcase_support
branch
from
55f1572 to
4a45ad1
Compare
anatol1234
force-pushed
the
rust_testcase_support
branch
3 times, most recently
from
153b18d to
835d52c
Compare
anatol1234
force-pushed
the
rust_testcase_support
branch
from
835d52c to
ca34e1a
Compare
anatol1234
force-pushed
the
rust_testcase_support
branch
from
817c22c to
2d847ba
Compare
anatol1234
force-pushed
the
rust_testcase_support
branch
2 times, most recently
from
e61db49 to
1b34483
Compare
anatol1234
force-pushed
the
rust_testcase_support
branch
from
1b34483 to
074465a
Compare
No description provided.