fix: code smells

graasp · Nov 27, 2024 · b6e37f9 · b6e37f9
1 parent 6825a73
commit b6e37f9
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 24 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,4 +1,8 @@
 {
   "files.trimTrailingWhitespace": true,
-  "eslint.useFlatConfig": true
+  "eslint.useFlatConfig": true,
+  "sonarlint.connectedMode.project": {
+    "connectionId": "graasp",
+    "projectKey": "graasp_graasp-account"
+  }
 }
diff --git a/cypress/e2e/account/homePage.cy.ts b/cypress/e2e/account/homePage.cy.ts
@@ -138,7 +138,7 @@ describe('Check member info', () => {
       'contain',
       MEMBER_WITH_AVATAR.name,
     );
-    const lang = MEMBER_WITH_AVATAR.extra.lang || 'en';
+    const lang = MEMBER_WITH_AVATAR.extra.lang ?? 'en';
     // displays the correct creation date
     const formattedDate = formatDistanceToNow(MEMBER_WITH_AVATAR.createdAt, {
       locale: getLocalForDateFns(lang),

diff --git a/cypress/e2e/account/settings/preferences.cy.ts b/cypress/e2e/account/settings/preferences.cy.ts
@@ -170,32 +170,30 @@ describe('Edit preferences', () => {
     });
   });
 
-  describe('Email Frequency', () => {
-    [
-      { initial: EmailFrequency.Never, final: EmailFrequency.Always },
-      { initial: EmailFrequency.Always, final: EmailFrequency.Never },
-    ].forEach(({ initial, final }) => {
-      it(`From ${initial} to ${final}`, () => {
-        cy.setUpApi({
-          currentMember: {
-            ...CURRENT_MEMBER,
-            extra: {
-              ...CURRENT_MEMBER.extra,
-              emailFreq: initial,
-            },
+  [
+    { initial: EmailFrequency.Never, final: EmailFrequency.Always },
+    { initial: EmailFrequency.Always, final: EmailFrequency.Never },
+  ].forEach(({ initial, final }) => {
+    it(`Email Frequency from ${initial} to ${final}`, () => {
+      cy.setUpApi({
+        currentMember: {
+          ...CURRENT_MEMBER,
+          extra: {
+            ...CURRENT_MEMBER.extra,
+            emailFreq: initial,
           },
-        });
-        cy.visit(ACCOUNT_SETTINGS_PATH);
-        cy.wait('@getCurrentMember');
-        cy.get(`#${PREFERENCES_EDIT_BUTTON_ID}`).click();
+        },
+      });
+      cy.visit(ACCOUNT_SETTINGS_PATH);
+      cy.wait('@getCurrentMember');
+      cy.get(`#${PREFERENCES_EDIT_BUTTON_ID}`).click();
 
-        switchEmailFreq(final);
+      switchEmailFreq(final);
 
-        cy.get(`#${PREFERENCES_SAVE_BUTTON_ID}`).click();
+      cy.get(`#${PREFERENCES_SAVE_BUTTON_ID}`).click();
 
-        cy.wait('@editMember').then(({ request }) => {
-          expect(request.body.extra.emailFreq).to.equal(final);
-        });
+      cy.wait('@editMember').then(({ request }) => {
+        expect(request.body.extra.emailFreq).to.equal(final);
       });
     });
   });