Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update i18n config #433

Merged
merged 7 commits into from
Nov 12, 2024
Merged

fix: update i18n config #433

merged 7 commits into from
Nov 12, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Nov 11, 2024

This PR is on top of #432

Copy link

gitguardian bot commented Nov 11, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14078705 Triggered Generic Password 44e97e9 cypress/e2e/settings/password.cy.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@spaenleh spaenleh requested a review from pyphilia November 12, 2024 12:42
@spaenleh spaenleh self-assigned this Nov 12, 2024
@spaenleh spaenleh added the feature New feature or request label Nov 12, 2024
@spaenleh spaenleh force-pushed the update-i18n-config branch 3 times, most recently from 8cd3d73 to 7d88342 Compare November 12, 2024 13:09
Copy link

Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added some suggestions^^

public/locales/en/enums.json Show resolved Hide resolved
src/main.tsx Show resolved Hide resolved
@spaenleh spaenleh added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit b0c10a9 Nov 12, 2024
4 checks passed
@spaenleh spaenleh deleted the update-i18n-config branch November 13, 2024 13:43
spaenleh pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants