Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Do we need to un-localise the language ? #440

Closed
spaenleh opened this issue Nov 12, 2024 · 1 comment
Closed

[i18n] Do we need to un-localise the language ? #440

spaenleh opened this issue Nov 12, 2024 · 1 comment
Labels
v2.18.0

Comments

@spaenleh
Copy link
Member 

          I think it's okay to pass `it-CH`, I think it should default to `it` automatically, or maybe we need some config in i18n https://www.i18next.com/overview/api#languages

Originally posted by @pyphilia in #433 (comment)

If using the language detector plugin from i18n, this could be a non-issue. Only dependency and integration with other library already providing their own internationalisation could be problematic (see date-fns relative date formatting).
spaenleh added a commit that referenced this issue Nov 14, 2024
@gitlocalize-app @mt-gitlocalize @spaenleh
fix(german): update translations (#440)
d5bc52b 
* fix(german): update translations

* fix(german): update translations

---------

Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>
Co-authored-by: Basile Spaenlehauer <spaenleh@gmail.com>
spaenleh pushed a commit that referenced this issue Nov 26, 2024
@renovate
chore(deps): update actions/upload-artifact action to v4 (#440)
484fc5d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@spaenleh
Copy link
Member Author

Closing as we are now using the language detector plugin from i18n

spaenleh added a commit that referenced this issue Dec 16, 2024
@spaenleh
fix: update use of descendants to filter on app type (#440)
e3943c6 
* fix: update use of descendants to filter on app type

* fix: apply review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2.18.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spaenleh