Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter children in useChildren directly #1031

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Feb 23, 2024

this is linked to graasp/graasp#831.

@ReidyT ReidyT self-assigned this Feb 23, 2024
- Because the cache is invalidated and API is mocked, the received items remain unchanged
- It is not feasible to verify ws updates without real backend
@ReidyT ReidyT marked this pull request as ready for review February 26, 2024 08:58
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe a slight change in the test so it's a little more complete 🛋️

cypress/e2e/item/move/listMoveMultiple.cy.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants