Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add umami tags to track actions #1500

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add umami tags to track actions #1500

wants to merge 6 commits into from

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Oct 3, 2024 •
edited
Loading

In this PR:

  • add umami script
  • add umami events on the home page

Still todo is #1502

Umami-events (1)

closes #1495

@spaenleh spaenleh self-assigned this Oct 3, 2024
@spaenleh spaenleh added the feature New feature or request label Oct 3, 2024
pyphilia
pyphilia requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! Let me know what you think of my suggestion.
I think event-page should be always returned?

index.html Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/main/Main.tsx Show resolved Hide resolved
src/components/main/MainMenu.tsx Show resolved Hide resolved
src/components/common/SelectTypes.tsx Show resolved Hide resolved
src/components/main/NewItemButton.tsx Show resolved Hide resolved
src/components/main/NewItemButton.tsx Show resolved Hide resolved
src/components/main/Main.tsx Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh requested a review from pyphilia October 8, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT Awaiting requested review from ReidyT

@pyphilia pyphilia Awaiting requested review from pyphilia

Requested changes must be addressed to merge this pull request.

Assignees

@spaenleh spaenleh

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup Umami for tracking
2 participants
@spaenleh @pyphilia