This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
Change Share
icon and improve layout of item header actions
#566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I propose to change the
Share
icon to better represent that this menu is related to sharing with people.Previously:
Proposed change:
And the link box was styled with the
text-overflow: ellipsis
to better show the link could not be displayed fully:IconButtons were also all wrapped in
span
s to ensure they stay round.TODO:
@graasp/ui
with the changes from 242 change share button icon graasp-ui#245 and graasp/graasp-ui@8877111Change
Favorite Items
icon from a heart to a star to be in ligne with theAdd to Favorites
icon in item actions.closes #550