Skip to content

Commit

Permalink
fix: rename chatbox title (#602)
Browse files Browse the repository at this point in the history
* fix: rename chatbox title

* fix: apply request changes

---------

Co-authored-by: Kim Lan Phan Hoang <pyphilia@gmail.com>
  • Loading branch information
mariembencheikh and pyphilia authored Apr 10, 2024
1 parent 0c49e6a commit 22a99cd
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/langs/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ export const PLAYER = {
FALLBACK_RELOAD_PAGE: 'FALLBACK_RELOAD_PAGE',
ITEM_ID_NOT_VALID: 'ITEM_ID_NOT_VALID',
GO_TO_HOME: 'GO_TO_HOME',
ITEM_CHATBOX_TITLE: 'ITEM_CHATBOX_TITLE',
};
3 changes: 2 additions & 1 deletion src/langs/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@
"FALLBACK_TEXT": "Something went wrong. Please try again. If the issue persists contact us.",
"FALLBACK_RELOAD_PAGE": "Reload page",
"ITEM_ID_NOT_VALID": "Item Id is not valid, please check it again. Click on the button below to go back to Home.",
"GO_TO_HOME": "Go to Home"
"GO_TO_HOME": "Go to Home",
"ITEM_CHATBOX_TITLE": "\"{{name}}\" Chat"
}
3 changes: 2 additions & 1 deletion src/langs/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@
"ERROR_FETCHING_ITEM": "Une erreur s'est produite lors de la récupération de l'élément",
"ERROR_ACCESSING_ITEM": "Vous ne pouvez pas accéder à cet élément",
"ERROR_ACCESSING_ITEM_HELPER": "Votre compte actuel n'a pas les droits pour accéder à cet élément.",
"SIGN_IN_BUTTON_TEXT": "Se connecter avec un autre compte"
"SIGN_IN_BUTTON_TEXT": "Se connecter avec un autre compte",
"ITEM_CHATBOX_TITLE": "Discussion pour \"{{name}}\""
}
4 changes: 3 additions & 1 deletion src/modules/rightPanel/SideContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ const SideContent = ({ content, item }: Props): JSX.Element | null => {
return (
<div id={CHATBOX_DRAWER_ID}>
<SideDrawer
title={t('Chat')}
title={t(PLAYER.ITEM_CHATBOX_TITLE, {
name: item.name,
})}
onClose={toggleChatbox}
open={isChatboxOpen}
>
Expand Down

0 comments on commit 22a99cd

Please sign in to comment.