Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update query-client to use v5 #848

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Sep 13, 2024

No description provided.

@ReidyT

This comment was marked as outdated.

@ReidyT

This comment was marked as outdated.

@ReidyT
Copy link
Contributor Author

ReidyT commented Sep 17, 2024

Thanks to @spaenleh, the simplest way to fix this issue, is to derivate the focusedItem from the itemsToShow.

@ReidyT ReidyT self-assigned this Sep 17, 2024
@ReidyT ReidyT force-pushed the 889-migrate-react-query-v5 branch 2 times, most recently from 26e379e to 49ab0c6 Compare September 30, 2024 10:00
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

package.json Outdated Show resolved Hide resolved
cypress/e2e/shuffle.cy.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔆

@ReidyT ReidyT force-pushed the 889-migrate-react-query-v5 branch 3 times, most recently from 37140f2 to 9ae6c47 Compare October 2, 2024 09:47
Copy link

sonarcloud bot commented Oct 2, 2024

@ReidyT ReidyT added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 19cd78a Oct 2, 2024
4 checks passed
@ReidyT ReidyT deleted the 889-migrate-react-query-v5 branch October 2, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants