fix: update ThemeProvider children type to be used with conditional r…

…endering (#1067) * fix: update ThemeProvider children type to be used with conditional rendering * fix: remove default label
graasp · Sep 30, 2024 · 5794e9e · 5794e9e
1 parent 609ea8c
commit 5794e9e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/ThemeContext/LanguageSelect.tsx b/src/ThemeContext/LanguageSelect.tsx
@@ -15,7 +15,7 @@ const LanguageSelect = ({
  setDirection,
  languageSelectSx,
  langs,
- label = 'Language',
+ label,
  size,
  variant,
 }: {

diff --git a/src/ThemeContext/ThemeContext.tsx b/src/ThemeContext/ThemeContext.tsx
@@ -9,7 +9,14 @@ import {
  SxProps,
 } from '@mui/material';
 
-import { createContext, useContext, useEffect, useMemo, useState } from 'react';
+import {
+ ReactNode,
+ createContext,
+ useContext,
+ useEffect,
+ useMemo,
+ useState,
+} from 'react';
 
 import rtlPlugin from '@graasp/stylis-plugin-rtl';
 
@@ -18,7 +25,7 @@ import { I18nInstance } from '../types.js';
 import LanguageSelect from './LanguageSelect.js';
 
 type Props = {
- children: JSX.Element | JSX.Element[];
+ children: ReactNode;
  i18n: I18nInstance;
  langs: { [key: string]: string };
  languageSelectSx: SxProps;