Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on allowing to configure platform? #18

Merged
merged 3 commits into from
Mar 14, 2020

Conversation

davidmcraejr
Copy link
Contributor

We use different pods for different platforms and some don't compile for both iOS and Watch as an example, doing something like this would allow us to make different merges for each platform as needed.

@biocross
Copy link

biocross commented Jan 17, 2020

Hello @dmac81, thank you for your PR.

Can you please tell me a little more about what use case does this MR solve? Unfortunately, the plugin itself does not take into account platforms other than iOS at this time, so I'm curious if the changes in the MR enough to solve your use case?

@davidmcraejr
Copy link
Contributor Author

@biocross So we have two platforms in our Podfile (watch and iOS) when we include pods that will only work on iOS and not Watch then those will fail to build because the script here will pickup and include both iOS and Watch in the "merged" podfile. This allows us to override the default behavior of finding all platforms in the main podfile and putting them in the merged podfile and will utilize the platform set for each group. I haven't looked deep enough into the code to determine what else would need to be done to support other platforms, we are starting with our iOS ones first, but would think this change would allow for a simple use case at least.

@biocross
Copy link

biocross commented Jan 21, 2020

@dmac81 got it. Can you just please share an example on how you'd override this in the MergeFile / Podfile? That way I can also update the README with this.

@davidmcraejr
Copy link
Contributor Author

@biocross let me know if that works for you

@ivanrnld ivanrnld merged commit e0c9e88 into grab:master Mar 14, 2020
@biocross
Copy link

@dmac81 Thanks a lot for this PR. I'll release a new version of the plugin with these changes soon.

@M4kxjci M4kxjci linked an issue May 7, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

int
3 participants