Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async and data integrity protections #5

Merged
merged 9 commits into from
Jul 24, 2020

Conversation

half-duplex
Copy link
Contributor

  • Write CSV using library
  • Overwrite CSV with an atomic rename()
  • Lock while checking/modifying/writing token list
  • Command callback in a Task, since library doesn't seem to (??)
  • Replace print()s with logging (and separate some verbose nio logging)
  • Log of token reuse attempts and some other stuff
  • User feedback for notice command
  • Reinvite users sending their token again to the community, not just rooms
  • Format using black, lint with flake8, check with github actions
  • I've probably forgotten some stuff

@half-duplex half-duplex force-pushed the async-tokens branch 2 times, most recently from 7294780 to 2e6a579 Compare July 24, 2020 02:38
@lovelaced
Copy link
Collaborator

Wow, looks great! Thank you!
We specifically do not want to re-invite users to a community because of a potential breakage in Matrix (ref matrix-org/synapse#2633 )

@gracchus163 gracchus163 merged commit 89dbcd1 into gracchus163:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants