Fix favicon in ssr mode (#9592)

* Fix favicon * fix * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
gradio-app · Oct 8, 2024 · 24fe222 · 24fe222
1 parent cc61fe7
commit 24fe222
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/thirty-insects-unite.md b/.changeset/thirty-insects-unite.md
@@ -0,0 +1,6 @@
+---
+"@self/app": minor
+"gradio": minor
+---
+
+feat:Fix favicon in ssr mode
diff --git a/gradio/routes.py b/gradio/routes.py
@@ -364,7 +364,7 @@ async def conditional_routing_middleware(
                     getattr(blocks, "node_process", None) is not None
                     and blocks.node_port is not None
                     and not path.startswith("/gradio_api")
-                    and path not in ["/config", "/login"]
+                    and path not in ["/config", "/login", "/favicon.ico"]
                     and not path.startswith("/theme")
                 ):
                     if App.app_port is None:

diff --git a/js/app/src/app.html b/js/app/src/app.html
@@ -2,7 +2,7 @@
 <html lang="en">
 	<head>
 		<meta charset="utf-8" />
-		<link rel="icon" href="%sveltekit.assets%/favicon.png" />
+		<link rel="icon" href="/favicon.ico" />
 		<meta name="viewport" content="width=device-width, initial-scale=1" />
 		%sveltekit.head%
 	</head>

diff --git a/js/app/static/favicon.png b/js/app/static/favicon.png