-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multipart
ModuleNotFoundError by renaming import to python_multipart
#10188
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/e364074fae7fee0a4afdd6c87de272f74f1fafbd/gradio-5.8.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@e364074fae7fee0a4afdd6c87de272f74f1fafbd#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/e364074fae7fee0a4afdd6c87de272f74f1fafbd/gradio-client-1.8.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/e364074fae7fee0a4afdd6c87de272f74f1fafbd/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Thanks @archiloque. You're right in making this change. It seems to be a consequence of this PR. We should rename the |
python_multipart
python_multipart
multipart
ModuleNotFoundError by renaming import to python_multipart
Merging, thanks again @archiloque! |
(I'm not experienced about Python's dependency and packaging, sorry if my analysis or suggestions are wrong)
I'm using Gradio on a project that depends on https://pypi.org/project/python-multipart/ through Gradio and https://pypi.org/project/multipart/ through another dependecy.
I tried to update the Gradio version to 5.8.0 and now I get an error at startup.
From Kludex/python-multipart#180 (comment) , my understanding is that the issue comes from the fact that python-multipart changed their package name to
python-multipart
with some compatibility, but the compatibility, but it doesn't work in my case.Since Gradio depends on
python-multipart>=0.0.18
, the code can be updated to use the new package name.I've tried to run the Gradio tests localy and they don't all pass on
main
even when using dev containers, but I don't see any new test failure after the change.As the fix is two lines of import, I feel that "please create an issue before you create this PR, unless the fix is very small" applies to this case.
Thanks !