Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion on code editor component #10733

Merged
merged 14 commits into from
Mar 11, 2025
Merged

Autocompletion on code editor component #10733

merged 14 commits into from
Mar 11, 2025

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Mar 5, 2025

Description

Context: internal link
Before implementing a customized autocompletion source, this PR just introduces the autocomplete option on gr.Code.

Light:
CleanShot 2025-03-10 at 19 04 36@2x

Dark:
CleanShot 2025-03-10 at 19 03 40@2x

In Playground:
CleanShot 2025-03-10 at 19 11 31@2x


If this PR is ok, I will try to implement the "smarter" autocompletion for Python using jedi

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 5, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/baf1bf401be55b468bbfd4e5afbcaa372d617e02/gradio-5.20.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@baf1bf401be55b468bbfd4e5afbcaa372d617e02#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/baf1bf401be55b468bbfd4e5afbcaa372d617e02/gradio-client-1.13.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/baf1bf401be55b468bbfd4e5afbcaa372d617e02/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 5, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/code minor
@gradio/lite minor
gradio minor
website minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Autocompletion on code editor component

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx requested a review from pngwn March 5, 2025 16:03
@whitphx whitphx marked this pull request as ready for review March 10, 2025 10:05
@whitphx whitphx changed the title Code autocompletion Autocompletion on code editor component Mar 10, 2025
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @whitphx! working as expected :)

Can we also add it to the lite playground element? Would just need to make the change here:

<Code
bind:value={code}
language="python"
lines={10}
readonly={!loaded}
dark_mode={active_theme_mode === "dark"}
/>

@whitphx
Copy link
Member Author

whitphx commented Mar 11, 2025

@aliabd Thank you! I forgot about it.. pushed the change adding it and will merge the PR once it passes the CI.

@whitphx whitphx merged commit 731ab92 into main Mar 11, 2025
23 checks passed
@whitphx whitphx deleted the code-autocomplete branch March 11, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants