-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static_columns
param for interactive dataframes
#10734
Conversation
I was thinking a padlock somewhere in the cell but it just looks too crowded. |
sgtm |
The current behavior doesn't seem to work well with adding/deleting columns. It depends on the use case, but for example, even if there is a column that the app developer wants to prevent users from changing, users can make it editable by adding a new column to its left. import gradio as gr
import numpy as np
with gr.Blocks() as demo:
gr.Dataframe(value=np.arange(15).reshape(3, 5), static_columns=[1], interactive=True)
demo.launch() 0.mp4 |
great catch @hysts. Perhaps we'll need to add some logic that if |
hmm I see. alternatively, we could remove the specified static column from static_columns if it's removed. but adding columns will also cause some confusing behaviour. i've updated the PR to set it to "fixed" if static columns are specified. thanks for reviewing @hysts! |
I reran @hysts's repro and I'm seeing a different issue with cell / header alignment being off: ![]() import gradio as gr
import numpy as np
with gr.Blocks() as demo:
gr.Dataframe(value=np.arange(15).reshape(3, 5), static_columns=[1], interactive=True)
demo.launch() |
@abidlabs fixed! my bad python code was the culprit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @hannahblair lgtm! We could consider adding a padlock symbol just in the header cell to designate a static column, but we don't have to do it now (or ever if it's a bad ui)
@abidlabs agreed, I'm happy with this now! ![]() |
Nice! |
Description
Adds a
static_columns
param, which takes a list ofint
s orstr
s to reference the columns. The use of static rows does feel potentially quite niche so we'll see if there are any requests for that.Closes: #2020
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh