Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: latex rendering of markdown #10765

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Conversation

Col0ring
Copy link
Contributor

@Col0ring Col0ring commented Mar 8, 2025

Description

The previous version requires the user's content to match all delimiters, which caused latex to not render correctly.

Closes: #10450

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 9, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/876809e9214cfa9dfa4989ffc6cea6ab85253372/gradio-5.20.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@876809e9214cfa9dfa4989ffc6cea6ab85253372#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/876809e9214cfa9dfa4989ffc6cea6ab85253372/gradio-client-1.13.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/876809e9214cfa9dfa4989ffc6cea6ab85253372/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 9, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/markdown-code patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

fix: latex rendering of markdown

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@dawoodkhan82 dawoodkhan82 self-requested a review March 10, 2025 18:15
Copy link
Collaborator

@dawoodkhan82 dawoodkhan82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks for fixing @Col0ring. Tested and fixes the issue.

@abidlabs abidlabs enabled auto-merge (squash) March 11, 2025 00:56
@abidlabs abidlabs merged commit 3232cdd into gradio-app:main Mar 11, 2025
23 of 24 checks passed
pngwn pushed a commit that referenced this pull request Mar 11, 2025
* fix: latex rendering of markdown

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Co-authored-by: Dawood Khan <dawoodkhan82@gmail.com>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latex delimiters issue with \(
4 participants