Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cell selection when using shift + arrow keys #10776

Merged
merged 7 commits into from
Mar 10, 2025

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Mar 10, 2025

Previously, we would treat the cell that was farthest to the left and top as the "anchor" cell, which would lead to interesting behavior when using shift+arrow keys. For example, here, I'm pressing on a cell, and then doing shift + up/left.

Screen.Recording.2025-03-10.at.1.18.29.PM.mov

In this PR:

Screen.Recording.2025-03-10.at.1.18.45.PM.mov

@abidlabs abidlabs requested a review from hannahblair March 10, 2025 20:10
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 10, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/3a7c5cf681f51d65c3472d92affc9d595064624b/gradio-5.20.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@3a7c5cf681f51d65c3472d92affc9d595064624b#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/3a7c5cf681f51d65c3472d92affc9d595064624b/gradio-client-1.13.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/3a7c5cf681f51d65c3472d92affc9d595064624b/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 10, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dataframe patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix cell selection when using shift + arrow keys

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Mar 10, 2025
@abidlabs abidlabs marked this pull request as ready for review March 10, 2025 20:19
Copy link
Collaborator

@hannahblair hannahblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @abidlabs!

@abidlabs abidlabs merged commit 85f6132 into main Mar 10, 2025
24 checks passed
@abidlabs abidlabs deleted the fix-arrow-key-df-selection branch March 10, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants