Allow navigating down from header cells, as well as support cmd/ctrl + arrow keys #10777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
abidlabs
changed the title
|
Header issue fixed!
Just to confirm, the new cmd/ctrl + arrow functionality is specifically jump navigation right? Works great. |
|
I'm gonna go ahead and merge this in, hope that's okay! |
|
Yes great thanks @hannahblair! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small issue: if you used the keyboard to navigate to the header cell, you couldn't navigate down to the regular table cells.
Before:
Screen.Recording.2025-03-10.at.1.51.53.PM.mov
Fixed:
Screen.Recording.2025-03-10.at.1.52.01.PM.mov
I also added support for navigating with cmd/ctrl+arrow keys, you can navigate through the dataframe pretty easily now:
Screen.Recording.2025-03-10.at.5.35.24.PM.mov
Closes: #7610 (the issue mentions a few bugs, which I've confirmed resolved. The issue also mentions home/end keys, which I'm not including in this PR, as they do not add any new functionality that cmd/ctrl+arrow keys already provide).